Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix field error in card API, reduce queries #11535 #11534

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix field error in card API, reduce queries #11535 #11534

merged 1 commit into from
Oct 31, 2024

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Oct 10, 2024 •
edited
Loading

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

  • Cope with removal of nodegroup PK on tilemodel in v8
  • Remove one query for graphs
  • Remove one query for nodes
  • Rename some variables for clarity

Closes #11535

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

@jacobtylerwalls jacobtylerwalls linked an issue Oct 10, 2024 that may be closed by this pull request
Card API view raises FieldError in v8 #11535
Closed
@jacobtylerwalls jacobtylerwalls changed the title Fix field error in card API, reduce queries Fix field error in card API, reduce queries #11535 Oct 10, 2024
@jacobtylerwalls jacobtylerwalls requested review from aarongundel and removed request for chiatt October 31, 2024 12:48
@jacobtylerwalls
Copy link
Member Author

@aarongundel I know you're spinning up on dev/8.0.x, so if you had the opportunity to take a look here, I figure it would give you a little exposure to one important 8.0 change (removal of FK from tile back to nodegroup). Thanks.

aarongundel
aarongundel approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@aarongundel aarongundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

@aarongundel aarongundel merged commit 4bfe5a9 into dev/8.0.x Oct 31, 2024
7 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/fix-card-api branch October 31, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongundel aarongundel aarongundel approved these changes

Assignees

@aarongundel aarongundel

Labels
Subject: Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Card API view raises FieldError in v8
2 participants
@jacobtylerwalls @aarongundel